Add ZeekBundle for integrating third-party components into our builds #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckreibich
force-pushed
the
topic/christian/prometheus-cpp
branch
from
4365698
to
d6048b7
Compare
timwoj
approved these changes
Jul 11, 2024
ZeekBundle.cmake
Outdated
| set(ZEEK_BUNDLE_PREFIX "${PROJECT_BINARY_DIR}/zeek-bundle" | ||
| CACHE STRING "Path to the Zeek packages cache directory") | ||
|
|
||
| # Opt-in to changed CMake behavior for fetch ZIP files. |
There was a problem hiding this comment.
Suggested change
| # Opt-in to changed CMake behavior for fetch ZIP files. | |
| # Opt-in to changed CMake behavior for fetching ZIP files. |
This provides an experimental alternative configuration & build approach for third-party submodules. It introduces a small CMake abstraction that will build the library separately at configuration time to isolate it from other targets. Then, we use `find_package` to pick up the (static) library from our build directory. For an example of its use, see Broker's CMakeLists.txt. Co-authored-by: Christian Kreibich <[email protected]>
ckreibich
force-pushed
the
topic/christian/prometheus-cpp
branch
from
d6048b7
to
ad08eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is exactly @Neverlord's #115, without the removal of
FindPrometheus.cmakeand with a bit of context in the commit message since development ofZeekBundle.cmakehappened in Dominik's Broker branch before moving over here.