Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -Werror in static plugin builds #102

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Pass -Werror in static plugin builds #102

merged 1 commit into from
Jan 8, 2024

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Jan 4, 2024

This PR corresponds to zeek/zeek#3528

awelzel
awelzel previously approved these changes Jan 5, 2024
Copy link
Contributor

@awelzel awelzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as elsewhere, can this be toggled in a pinch?

@awelzel awelzel dismissed their stale review January 5, 2024 16:09

Made assumptions this had been decided by the team.

@timwoj timwoj merged commit 01fcb68 into master Jan 8, 2024
1 check passed
@timwoj timwoj deleted the topic/timw/werror branch January 8, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants