Use a fork of ctor to silence warnings generated by macro
#3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeviant
commented
Nov 8, 2023
Cargo.toml
Outdated
| # TODO: Switch back to the published version of `ctor` once: | ||
| # 1. A new version of `ctor` is published with this change: https://github.com/mmastrac/rust-ctor/pull/295 | ||
| # 2. We've confirmed it's fine to update to the latest version of `ctor` (we're currently on v0.1.20). | ||
| ctor = { git = "https://github.com/deviant-forks/rust-ctor", rev = "9c03df5c5208fcc3545794168f3bccbb03a82c84" } |
There was a problem hiding this comment.
Do we want to create this fork under the zed-industries GitHub org?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches us over to a fork of
ctorthat contains the fixes from mmastrac/rust-ctor#295, backported to our current version ofctor(v0.1.20).Once 1) the
ctormaintainer publishes a new version with that change and 2) we're ready to upgrade to the latest version ofctorwe can switch back to the mainline version.Release Notes: