Skip to content

Add support for Standard Ruby's LSP server #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 24, 2025

Since pull-based diagnostics aren't supported yet, I wanted to see if it's possible to use Standard's built-in language server for diagnostics, but Ruby LSP for everything else.

Since Standard's LSP is based on RoboCop's, I've basically just copied the existing RuboCop implementation.

So far it appears to be working well. I was concerned about what might happen if format requests were sent to multiple language servers. But it seems the request is only sent to the first in the language_servers array.

If this is merged then the Ruby docs page should be updated to mention Standard.

@cla-bot cla-bot bot added the cla-signed label Mar 24, 2025
@andyw8 andyw8 marked this pull request as ready for review March 24, 2025 19:40
@@ -18,6 +18,10 @@ languages = ["Ruby", "ERB"]
name = "Rubocop"
languages = ["Ruby"]

[language_servers.standard]
name = "Standard"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether to call this Standard Ruby to avoid confusion with https://github.com/standard.

@andyw8
Copy link
Contributor Author

andyw8 commented Mar 25, 2025

Nevermind! Just noticed #25

@andyw8 andyw8 closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant