Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended status compatibility update for nginx 1.4.2 and 1.5.2 #6

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

david-benes
Copy link

Added patches for two latest nginx version.

@mklooss
Copy link

mklooss commented Nov 29, 2013

assigned, works perfect

…ned by module stub and thus rewriting 'waiting requests' status variable value
@luis-alen
Copy link

David, do you know whether one of your added patches will work with nginx 1.4.4?

Also, I noticed that your pull request has not been accepted yet. Do you know why? Has this project been discontinued?

@david-benes
Copy link
Author

Hi luis-alen, patch for 1.4.2 will certainly work for 1.4.4 also. There might be some warning during patching process that 'patch was applied with offset'. But that is nothing you need to be worried about.
What you should be concerned about is that this patch somehow breaks original 'stub' module, because shared memory of these two modules overlap. I already fixed that also - you should check out "1.4.2 patch" in my fork instead: https://github.com/david-benes/ngx_http_extended_status_module

We use nginx 1.4.4 in heavy production with 1.4.2 patch applied and we don't have any issues at all.
I gave up waiting for this patch to be accepted here, so I made my own fork just for patching purposes.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants