Land rapid7#19336, Fix SSH scanner tests when report summary enabled

zdi-team · Jul 22, 2024 · 1108afb · 1108afb
2 parents db5ace8 + ba52331
commit 1108afb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/msf/core/auxiliary/report_summary.rb b/lib/msf/core/auxiliary/report_summary.rb
@@ -44,7 +44,7 @@ def run
       # @param [Hash] credential_data
       # @return [Metasploit::Credential::Login]
       def create_credential_login(credential_data)
-        return super unless framework.features.enabled?(Msf::FeatureManager::SHOW_SUCCESSFUL_LOGINS) && datastore['ShowSuccessfulLogins']
+        return super unless framework.features.enabled?(Msf::FeatureManager::SHOW_SUCCESSFUL_LOGINS) && datastore['ShowSuccessfulLogins'] && @report
 
         credential = {
           public: credential_data[:username],
@@ -65,7 +65,7 @@ def create_credential_login(credential_data)
       # @param [Msf::Sessions::<SESSION_CLASS>] sess
       # @return [Msf::Sessions::<SESSION_CLASS>]
       def start_session(obj, info, ds_merge, crlf = false, sock = nil, sess = nil)
-        return super unless framework.features.enabled?(Msf::FeatureManager::SHOW_SUCCESSFUL_LOGINS) && datastore['ShowSuccessfulLogins']
+        return super unless framework.features.enabled?(Msf::FeatureManager::SHOW_SUCCESSFUL_LOGINS) && datastore['ShowSuccessfulLogins'] && @report
 
         result = super
         @report[rhost].merge!({ successful_sessions: [] })