-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zcash_client_sqlite: Add methods for fixing broken note commitment trees. #1709
base: main
Are you sure you want to change the base?
Conversation
534d723
to
b475012
Compare
ee5c933
to
2178806
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
- Coverage 54.27% 53.96% -0.31%
==========================================
Files 179 179
Lines 21253 21374 +121
==========================================
Hits 11535 11535
- Misses 9718 9839 +121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
71c9eb6
to
f39a932
Compare
f39a932
to
6e2e269
Compare
ef58f07
to
39360f5
Compare
This appears to work: the However, the branch it is within does not get fully merged, because the act of re-scanning the previously-scanned range causes a frontier to be inserted, which marks the leaf just before the re-scanned range as I suspect the solution here is to check the scan status of the block containing the frontier when inserting it, and only marking the frontier as |
39360f5
to
b006e39
Compare
This functionality is needed in order to make it possible for wallets that have corrupted note commitment tree state to recover from that situation.