Skip to content

Commit

Permalink
Merge pull request #9 from zbw/keep-invalid-isbn
Browse files Browse the repository at this point in the history
Don't translate Invalid ISBN in Poppy and Quesnelia
  • Loading branch information
hemmefelix authored May 2, 2024
2 parents 44667db + fa82628 commit 5ba7cd9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,12 @@ For example
cd german
./update-translations https://folio-demo.gbv.de/okapi diku diku_admin admin
```

## Invalid ISBN

The identifier type `Invalid ISBN` (`/identifier-types/fcca2643-406a-482a-b760-7a7f8aec640e`) must not
be translated in Poppy and Quesnelia because mod-orders and mod-search reference it by name and not by id.

This gets fixed for Ramsons:
* [MODORDERS-1094](https://folio-org.atlassian.net/browse/MODORDERS-1094)
* [MSEARCH-743](https://folio-org.atlassian.net/browse/MSEARCH-743)
2 changes: 1 addition & 1 deletion german/identifier-types.tsv
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ fc4e3f2a-887a-46e5-8057-aeeb271a4e56 Cancelled system control number Gelöschte/
39554f54-d0bb-4f0a-89a4-e422f6136316 DOI DOI
351ebc1c-3aae-4825-8765-c6d50dbf011f GPO item number GPO-Exemplarnummer
216b156b-215e-4839-a53e-ade35cb5702a Handle Handle
fcca2643-406a-482a-b760-7a7f8aec640e Invalid ISBN Formal falsche ISBN
fcca2643-406a-482a-b760-7a7f8aec640e Invalid ISBN Invalid ISBN
27fd35a6-b8f6-41f2-aa0e-9c663ceb250c Invalid ISSN Formal falsche ISSN
8261054f-be78-422d-bd51-4ed9f33c3422 ISBN ISBN
913300b2-03ed-469a-8179-c1092c991227 ISSN ISSN
Expand Down

0 comments on commit 5ba7cd9

Please sign in to comment.