splash image support #587
Merged
splash image support #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdykstra
reviewed
Feb 3, 2024
classabbyamp
force-pushed
the
splish-splash-i-was-takin-a-bath
branch
from
87b9e1c to
45e4a69
Compare
|
Tested successfully on a Dell laptop, looks nice! |
|
On my hardware, at least, the ZBM splash is jarring/out of place due to the Lenovo logo disappearing and then reappearing before the countdown screen is shown. I'd rather not see release/recovery EFIs exhibiting that behavior, even if it is likely nothing under our control. With that said, it does look good on certain hardware - just not any of mine. |
classabbyamp
force-pushed
the
splish-splash-i-was-takin-a-bath
branch
from
45e4a69 to
3377a1d
Compare
supported on more versions of linux (6.2+ without EFI_HANDOVER) and supports more features (like splash images, better secureboot support)
classabbyamp
force-pushed
the
splish-splash-i-was-takin-a-bath
branch
from
3377a1d to
b1d3b6e
Compare
zdykstra
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now we're a real bootloader