releng/make-binary.sh: specify release tag in builder images by default #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdykstra
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
As near as I can tell, releng/docker/image-build.sh just records arg 2 in the container that's built, but doesn't actually do anything else with it.
As long as the vX.X tag is pushed to the repository before build-init.sh is run, it's safe to record this tag in the build container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing and backporting to v2.3.x before another release is tagged, but this ensures that we create images during releng that will build the release that is being tagged.