-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use args_from_dict
in all camera classes
#257
base: main
Are you sure you want to change the base?
Conversation
and use `args_from_dict` in `RtspCamera`
I added some tests for this. What do you think? |
Some notes: We do not actually test the functionality that we just fixed. A base I'll look into fixing those two points. |
tests: test calibratable subclasses
seems a little overkill in hindsight but that is what I ended up with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to wrap this line. It's shorter than 120 characters.
from_dict
inUsbCamera
andMjpegCamera
args_from_dict
inRtspCamera