Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google one-tap authentication example #3244

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Google one-tap authentication example #3244

wants to merge 4 commits into from

Conversation

rodja
Copy link
Member

@rodja rodja commented Jun 19, 2024 •
edited
Loading

This pull request is inspired by #3243 and shows how we can use Google one-tap authentication with NiceGUI.

@rodja rodja added the enhancement New feature or request label Jun 19, 2024
@rodja rodja added this to the 1.4.28 milestone Jun 19, 2024
@rodja rodja marked this pull request as ready for review June 27, 2024 03:17
@falkoschindler falkoschindler modified the milestones: 1.4.28, 1.4.29 Jun 28, 2024
falkoschindler
falkoschindler requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the demo doesn't work for me:
"Can't continue with google.com. Something went wrong."

Apart from that, I think we should add dotenv to a requirements file.

@falkoschindler falkoschindler self-requested a review July 1, 2024 20:22
falkoschindler
falkoschindler requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm still getting the same error.
Strangely, NiceGUI connects to "us-west.on-air.io"... But the authentication should work nonetheless I guess.
And the corresponding startup test is failing for some reason.

@falkoschindler falkoschindler modified the milestones: 1.4.29, 1.4.30 Jul 9, 2024
@falkoschindler falkoschindler modified the milestones: 1.4.30, 1.4.31 Jul 26, 2024
@falkoschindler falkoschindler modified the milestones: 1.4.31, 2.x Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler requested changes

Assignees

@rodja rodja

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@rodja @falkoschindler