-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy 2.0 compatibility #535
Conversation
a39822f
to
25d6a82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this it a good solution. I will merge tomorrow if there are no objections.
We should track numpy 2.0 support in zfpy, though.
I updated this so the Python 3.10 tests use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2318 2318
=======================================
Hits 2316 2316
Misses 2 2 |
Fixes #521.
Currently the solution is to just test without zfpy support, which is easy to implement. In an ideaL world I guess we want to run at least one test with zfpy and
numpy<2
? I won't have time to implement that in the next few days, so someone else feel free to take over and do that if desirable.