Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDE-4087] chore(cli, core, schema): v16 followup - update version-store and package .nvmrc #940

Merged
merged 2 commits into from
Dec 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v18
4 changes: 2 additions & 2 deletions packages/cli/src/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const BLOCKLISTED_PATHS = [
];
const NODE_VERSION = versionStore[versionStore.length - 1].nodeVersion;
const LAMBDA_VERSION = `v${NODE_VERSION}`;
const NODE_VERSION_CLI_REQUIRES = '>=16'; // should be the oldest non-ETL version
const NODE_VERSION_CLI_REQUIRES = '>=18'; // should be the oldest non-ETL version
const AUTH_KEY = 'deployKey';
const ANALYTICS_KEY = 'analyticsMode';
const ANALYTICS_MODES = {
Expand All @@ -42,7 +42,7 @@ const PACKAGE_VERSION = packageJson.version;
const UPDATE_NOTIFICATION_INTERVAL = 1000 * 60 * 60 * 24 * 7; // one week

const CHECK_REF_DOC_LINK =
'https://platform.zapier.com/docs/integration-checks-reference';
'https://docs.zapier.com/platform/publish/integration-checks-reference#integration-check-reference';

const ISSUES_URL =
'https://github.com/zapier/zapier-platform/issues/new/choose';
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/version-store.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ module.exports = [
{ nodeVersion: '14', npmVersion: '>=5.6.0' }, // 12.x
{ nodeVersion: '16', npmVersion: '>=5.6.0' }, // 13.x
{ nodeVersion: '18', npmVersion: '>=5.6.0' }, // 15.x
{ nodeVersion: '18', npmVersion: '>=10.7.0' }, // 16.x
];
2 changes: 1 addition & 1 deletion packages/core/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v18
2 changes: 1 addition & 1 deletion packages/legacy-scripting-runner/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v18
2 changes: 1 addition & 1 deletion packages/schema/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v18
Loading