Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(legacy-scripting-runner): [PDE-5515] Revert "Install aws-sdk v2 for legacy-scripting-runner" #916

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

rnegron
Copy link
Member

@rnegron rnegron commented Nov 14, 2024

This reverts commit a35081b.

Bundling in aws-sdk really bloats the boilerplate zip file so we're going to tackle this problem on an integration-by-integration basis. See Slack thread for details: https://zapier.slack.com/archives/C5Z9BP4U9/p1731506889913249?thread_ts=1731431960.425939&cid=C5Z9BP4U9

…or legacy-scripting-runner (#912)"

This reverts commit a35081b.
@rnegron rnegron requested a review from a team as a code owner November 14, 2024 13:17
Copy link
Contributor

@kreddlear kreddlear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this makes sense to me 👍 Darn, such a bummer that it bloated the boilerplate so much 🤔

@rnegron rnegron merged commit 98b65b6 into main Nov 19, 2024
14 checks passed
@rnegron rnegron deleted the PDE-5515-followup branch November 19, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants