Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #733 - Add M365 Graph channel guide #738

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Conversation

ralf401
Copy link
Contributor

@ralf401 ralf401 commented Jan 7, 2025

No description provided.

@ralf401 ralf401 self-assigned this Jan 7, 2025
@ralf401 ralf401 linked an issue Jan 7, 2025 that may be closed by this pull request
@ralf401 ralf401 requested a review from dvuckovic January 8, 2025 10:39
channels/microsoft365/m365-graph/index.rst Outdated Show resolved Hide resolved
channels/microsoft365/m365-graph/index.rst Outdated Show resolved Hide resolved
channels/microsoft365/m365-graph/index.rst Outdated Show resolved Hide resolved
channels/microsoft365/index.rst Outdated Show resolved Hide resolved
@ralf401 ralf401 changed the title Draft: Fixes #733 - Add M365 Graph channel guide Fixes #733 - Add M365 Graph channel guide Jan 8, 2025
@ralf401
Copy link
Contributor Author

ralf401 commented Jan 9, 2025

Hi @dominikklein & @mantas,

can you please have a look at the changes in the PR? @dvuckovic already had a look and suggested to also ask you for feedback. It would be interesting if you could especially have a look at the common errors section if there is something missing.

You can download the HTML-Zip here
.

Copy link
Contributor

@dominikklein dominikklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general nice work :-) Only some small comments/questions.

Personally I would love some screenshots for some important things, at least to give some better feeling as an addition to the only text description (e.g. finding correct places in entry, but maybe the people are normaly experts in Microsoft world?).
I saw that nothing related to admin consent is mentioned and also nothing about re-authentication.

channels/microsoft365-graph/accounts.rst Show resolved Hide resolved
channels/microsoft365-graph/accounts.rst Outdated Show resolved Hide resolved
channels/microsoft365-graph/accounts.rst Outdated Show resolved Hide resolved
@ralf401
Copy link
Contributor Author

ralf401 commented Jan 9, 2025

I saw that nothing related to admin consent is mentioned and also nothing about re-authentication.

I added 2 small sections at the bottom of the page about it.

Personally I would love some screenshots for some important things ...

I added now some screenshots. Let me know if you consider them the right ones ;-)

Download here.

@ralf401 ralf401 merged commit e7ecb9d into pre-release Jan 9, 2025
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/733 branch January 9, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve and create new Documentation MS365
3 participants