Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hlapi): add gpu selection #1990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(hlapi): add gpu selection #1990

wants to merge 1 commit into from

Conversation

tmontaigu
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Jan 17, 2025
IceTDrinker
IceTDrinker reviewed Jan 17, 2025
View reviewed changes
tfhe/src/core_crypto/gpu/vec.rs
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub struct GpuIndex(pub u32);

impl GpuIndex {
pub fn num_gpus() -> u32 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we prefer X_count instead of num_X ? At least that's what we have in core and several parts of the code base? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmontaigu @IceTDrinker