-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all): update toolchain #1932
base: main
Are you sure you want to change the base?
Conversation
0d22a5a
to
35d5804
Compare
failed wasm tests |
35d5804
to
46050ae
Compare
46050ae
to
59ce366
Compare
seeing the errors you are probably trying to target a toolchain that's too recent wrt to the stable one, I would try re running tests though as rust 1.84 has just released yesterday I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To retry or have a less recent toolchain
59ce366
to
604786c
Compare
604786c
to
3205f10
Compare
For the typo checker, you should not add this folder as an exclude, it is the previous localization before it was moved. Removing the folder locally should fix the issue for you. Typo checker follows the gitignore so I think you can just remove the commit. |
caa3640
to
4d6551c
Compare
4d6551c
to
510e1dc
Compare
@@ -76,7 +76,7 @@ tfhe-versionable = { version = "0.4.0", path = "../utils/tfhe-versionable" } | |||
wasm-bindgen = { workspace = true, features = [ | |||
"serde-serialize", | |||
], optional = true } | |||
wasm-bindgen-rayon = { version = "=1.2.2", optional = true } | |||
wasm-bindgen-rayon = { version = "1.3.0", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayeul-zama could you rm -rf tfhe/pkg and check the content of the generated pkg for the parallel API ? to know what the packaging will look like
the test failure is linked to my question about packaging https://github.com/zama-ai/tfhe-rs/actions/runs/12827028832/job/35768218506 |
still some incompatible toolchain stuff, stop working on the toolchain update, this is becoming a waste of time |
we'll wait for 1.85 with rust 2024 to come out to start again, in the meantime the deps updates are useful |
510e1dc
to
8a5357b
Compare
No description provided.