Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): update toolchain #1932

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(all): update toolchain #1932

wants to merge 3 commits into from

Conversation

mayeul-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 8, 2025
@mayeul-zama mayeul-zama requested review from nsarlin-zama, agnesLeroy, IceTDrinker and tmontaigu and removed request for agnesLeroy January 9, 2025 09:00
@IceTDrinker
Copy link
Member

failed wasm tests

@IceTDrinker
Copy link
Member

seeing the errors you are probably trying to target a toolchain that's too recent wrt to the stable one, I would try re running tests though as rust 1.84 has just released yesterday I believe

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To retry or have a less recent toolchain

@nsarlin-zama
Copy link
Contributor

nsarlin-zama commented Jan 13, 2025

For the typo checker, you should not add this folder as an exclude, it is the previous localization before it was moved. Removing the folder locally should fix the issue for you.

Typo checker follows the gitignore so I think you can just remove the commit.

@mayeul-zama mayeul-zama force-pushed the mz/update_toolchain branch 6 times, most recently from caa3640 to 4d6551c Compare January 17, 2025 09:37
@@ -76,7 +76,7 @@ tfhe-versionable = { version = "0.4.0", path = "../utils/tfhe-versionable" }
wasm-bindgen = { workspace = true, features = [
"serde-serialize",
], optional = true }
wasm-bindgen-rayon = { version = "=1.2.2", optional = true }
wasm-bindgen-rayon = { version = "1.3.0", optional = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayeul-zama could you rm -rf tfhe/pkg and check the content of the generated pkg for the parallel API ? to know what the packaging will look like

@IceTDrinker
Copy link
Member

the test failure is linked to my question about packaging

https://github.com/zama-ai/tfhe-rs/actions/runs/12827028832/job/35768218506

@IceTDrinker
Copy link
Member

still some incompatible toolchain stuff, stop working on the toolchain update, this is becoming a waste of time

@IceTDrinker
Copy link
Member

we'll wait for 1.85 with rust 2024 to come out to start again, in the meantime the deps updates are useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants