Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pbs): slightly improve f64 pbs perf #1498

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

sarah-quinones
Copy link

@sarah-quinones sarah-quinones commented Aug 29, 2024

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments/question on the rounding stuff

Copy link

cla-bot bot commented Sep 3, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: sarah el kazdadi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Sep 3, 2024
Copy link

cla-bot bot commented Sep 3, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: sarah el kazdadi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Sep 3, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: sarah el kazdadi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Sep 3, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: sarah el kazdadi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@IceTDrinker IceTDrinker merged commit 15e3474 into main Sep 3, 2024
142 checks passed
@IceTDrinker IceTDrinker deleted the sk/feat/pbs-perf branch September 3, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants