feat(tfhe): replace asm with rust intrinsics #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-quinones
force-pushed
the
sk/feat/replace-asm
branch
from
92c4cb5 to
4d6ccfb
Compare
IceTDrinker
reviewed
Aug 26, 2024
| // SAFETY: simd contains an instance of avx512dq, that matches the target feature of | ||
| // `implementation` | ||
| unsafe { implementation(x) } | ||
| _ = simd; | ||
| unsafe { _mm512_cvttpd_epi64(x) } |
There was a problem hiding this comment.
is this going to get inlined if we don't have the target feature on the function itself ?
also could we maybe replace our function call by this intrinsics directly ?
last question, I think you said you had an improvement in performance by changing the conversion function ? here it seems it's the same ?
There was a problem hiding this comment.
should get inlined if it works like the other intrinsics.
i also figured I'd leave the instruction change for a separate pr
| // SAFETY: simd contains an instance of avx512dq, that matches the target feature of | ||
| // `implementation` | ||
| unsafe { implementation(x) } | ||
| _ = simd; | ||
| unsafe { _mm512_cvtepi64_pd(x) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: