Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integer): implement sub_assign_with borrow #1474

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tmontaigu
Copy link
Contributor

To get the same kind of speed ups for unsigned_overflow as we got in previous commits that changed the carry propagation algorithm

@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
@tmontaigu tmontaigu force-pushed the tm/unsigned-overflowing-sub branch from 743ad17 to 6e3fa9a Compare August 16, 2024 10:06
@tmontaigu tmontaigu requested a review from IceTDrinker August 16, 2024 11:26
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, as per tradition

@tmontaigu tmontaigu force-pushed the tm/unsigned-overflowing-sub branch from 6e3fa9a to c4a0bf4 Compare August 19, 2024 10:10
To get the same kind of speed ups for unsigned_overflow
as we got in previous commits that changed the carry propagation
algorithm
@tmontaigu tmontaigu force-pushed the tm/unsigned-overflowing-sub branch from c4a0bf4 to 8256ff6 Compare August 19, 2024 17:07
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@tmontaigu tmontaigu merged commit 358bcc9 into main Aug 21, 2024
87 checks passed
@tmontaigu tmontaigu deleted the tm/unsigned-overflowing-sub branch August 21, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants