Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Al/remove host decoration #1455

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Al/remove host decoration #1455

merged 2 commits into from
Aug 6, 2024

Conversation

agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Aug 2, 2024 •
edited
Loading

closes: please link all relevant issues

PR content/description

Just some cleaning of the code.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@agnesLeroy agnesLeroy requested a review from bbarbakadze August 2, 2024 15:25
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
@agnesLeroy agnesLeroy force-pushed the al/remove_host_decoration branch from db0b710 to 583db6f Compare August 2, 2024 15:30
bbarbakadze
bbarbakadze approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@bbarbakadze bbarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@agnesLeroy agnesLeroy merged commit a26e68c into main Aug 6, 2024
79 checks passed
@agnesLeroy agnesLeroy deleted the al/remove_host_decoration branch August 6, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarbakadze bbarbakadze bbarbakadze approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @bbarbakadze @zama-bot