Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): remove remaining par_iter over gpu_indexes #1434

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore(gpu): remove remaining par_iter over gpu_indexes #1434

merged 1 commit into from
Jul 31, 2024

Conversation

agnesLeroy
Copy link
Contributor

Rename some variables to try and make the code clearer

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@agnesLeroy
chore(gpu): remove remaining par_iter over gpu_indexes
407a86c 
Rename some variables to try and make the code clearer
@agnesLeroy agnesLeroy requested a review from pdroalves July 30, 2024 11:07
@cla-bot cla-bot bot added the cla-signed label Jul 30, 2024
pdroalves
pdroalves approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. Naming seems better and it fixes a possible invalid access on the index vector for multi-gpus. Cool.

tfhe/src/core_crypto/gpu/slice.rs Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/bitwise_op.rs Show resolved Hide resolved
@agnesLeroy agnesLeroy merged commit 0a2ad8c into main Jul 31, 2024
107 of 108 checks passed
@agnesLeroy agnesLeroy deleted the al/remove_remaining_par_iter branch July 31, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdroalves pdroalves pdroalves approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @pdroalves @zama-bot