refactor(integer): add compression key types #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeul-zama
force-pushed
the
mz/integer_compression_key
branch
from
dcf3c11 to
73acc67
Compare
|
To merge after #1437 |
mayeul-zama
force-pushed
the
mz/integer_compression_key
branch
from
73acc67 to
cb3a793
Compare
mayeul-zama
force-pushed
the
mz/integer_compression_key
branch
from
cb3a793 to
1f55d61
Compare
mayeul-zama
force-pushed
the
mz/integer_compression_key
branch
from
1f55d61 to
2e6e49c
Compare
|
some GPU test crash related to the change at the moment it seems |
mayeul-zama
force-pushed
the
mz/integer_compression_key
branch
from
2e6e49c to
bd2a680
Compare
|
can you check if there are test cases for compression in the data repo ? |
IceTDrinker
reviewed
Aug 23, 2024
| radix_cks.new_cuda_compression_decompression_keys(&private_compression_key, &streams); | ||
| radix_cks.new_cuda_compression_decompression_keys(&private_compression_key.0, &streams); |
There was a problem hiding this comment.
I would move the .0 in the cuda code and make sure this interface uses an integer key
tfhe/src/integer/compression_keys.rs
Outdated
|
|
||
| #[derive(Clone, Debug, Serialize, Deserialize, Versionize)] | ||
| #[versionize(CompressionPrivateKeysVersions)] | ||
| pub struct CompressionPrivateKeys(pub crate::shortint::list_compression::CompressionPrivateKeys); |
There was a problem hiding this comment.
this is not consistent with other keys, they are struct with named fields, see e.g. tfhe/src/integer/server_key/mod.rs:36
There was a problem hiding this comment.
Replaced by a field named key
mayeul-zama
added
the
data_PR
mayeul-zama
force-pushed
the
mz/integer_compression_key
branch
from
bd2a680 to
d5f09bc
Compare
nsarlin-zama
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.