Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: try to trigger tests with simple changes #1152

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aws_tfhe_fast_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ env:
on:
# Allows you to run this workflow manually from the Actions tab as an alternative.
workflow_dispatch:
pull_request:
############"pull_request: debug
workflow_call:
secrets:
SLAB_ACTION_TOKEN:
Expand Down
26 changes: 23 additions & 3 deletions .github/workflows/aws_tfhe_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
csprng_test: ${{ steps.changed-files.outputs.csprng_any_changed }}
apps_test: ${{ steps.changed-files.outputs.apps_any_changed }}
user_docs_test: ${{ steps.changed-files.outputs.user_docs_any_changed }}
any_file_changed: ${{ steps.changed-files.outputs.any_changed }}
any_file_changed: ${{ steps.aggregated-changes.outputs.any_changed }}
steps:
- name: Checkout tfhe-rs
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b
Expand Down Expand Up @@ -71,11 +71,31 @@ jobs:
- tfhe/docs/**
- README.md

- name: Aggregate file changes
id: aggregated-changes
if: ( steps.changed-files.outputs.core_crypto_any_changed == 'true' ||
steps.changed-files.outputs.shortint_any_changed == 'true' )
run: |
echo "any_changed=true" >> "$GITHUB_OUTPUT"

- name: Echo results
run: |
echo "core_crypto_test: ${{ steps.changed-files.outputs.core_crypto_any_changed }}"
echo "boolean_test: ${{ steps.changed-files.outputs.boolean_any_changed }}"
echo "shortint_test: ${{ steps.changed-files.outputs.shortint_any_changed }}"
echo "c_api_test: ${{ steps.changed-files.outputs.c_api_any_changed }}"
echo "high_level_api_test: ${{ steps.changed-files.outputs.high_level_api_any_changed }}"
echo "examples_test: ${{ steps.changed-files.outputs.examples_any_changed }}"
echo "zk_pok_test: ${{ steps.changed-files.outputs.zk_pok_any_changed }}"
echo "csprng_test: ${{ steps.changed-files.outputs.csprng_any_changed }}"
echo "apps_test: ${{ steps.changed-files.outputs.apps_any_changed }}"
echo "user_docs_test: ${{ steps.changed-files.outputs.user_docs_any_changed }}"
echo "any_file_changed: ${{ steps.aggregated-changes.outputs.any_changed }}"
# TODO Ajouter une étape qui aggrège tous les résultats de "any_changed" en utilisant un any()

setup-instance:
name: Setup instance (cpu-tests)
#if: ${{ github.event_name == 'pull_request' && needs.file-change.outputs.any_file_changed == 'true' }}
if: ${{ github.event_name == 'pull_request' && needs.file-change.outputs.any_file_changed == 'true' }}
###############if: ${{ github.event_name == 'workflow_dispatch' || contains(github.event.label.name, 'approved') }}
needs: file-change
runs-on: ubuntu-latest
Expand All @@ -95,7 +115,7 @@ jobs:

cpu-tests:
name: CPU tests
needs: setup-instance
needs: [ file-change, setup-instance ]
concurrency:
group: ${{ github.workflow }}_${{ github.ref }}
cancel-in-progress: true
Expand Down
3 changes: 3 additions & 0 deletions tfhe/src/boolean/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ pub(crate) fn random_integer() -> u32 {
rng.gen::<u32>()
}
// A simple change
// A second simple change
// Again a change
// Blaaaaaaaaah

/// Generate a couple of client and server keys with the default cryptographic parameters:
/// `DEFAULT_PARAMETERS`.
Expand Down
1 change: 1 addition & 0 deletions tfhe/src/c_api/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ pub mod shortint;
pub(crate) mod utils;

// A simple change
// A second simple change
Loading