chore(gpu): remove duplicated test params

zama-ai · Feb 28, 2024 · 697ce94 · 697ce94
1 parent a667b65
commit 697ce94
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 64 deletions.
diff --git a/tfhe/src/core_crypto/gpu/algorithms/test/lwe_multi_bit_programmable_bootstrapping.rs b/tfhe/src/core_crypto/gpu/algorithms/test/lwe_multi_bit_programmable_bootstrapping.rs
@@ -8,24 +8,11 @@ use crate::core_crypto::gpu::{
 };
 use itertools::Itertools;
 
-pub struct MultiBitParams<Scalar: UnsignedInteger> {
-    pub input_lwe_dimension: LweDimension,
-    pub lwe_modular_std_dev: StandardDev,
-    pub decomp_base_log: DecompositionBaseLog,
-    pub decomp_level_count: DecompositionLevelCount,
-    pub glwe_dimension: GlweDimension,
-    pub polynomial_size: PolynomialSize,
-    pub glwe_modular_std_dev: StandardDev,
-    pub message_modulus_log: CiphertextModulusLog,
-    pub ciphertext_modulus: CiphertextModulus<Scalar>,
-    pub grouping_factor: LweBskGroupingFactor,
-}
-
 #[allow(clippy::too_many_arguments)]
 fn lwe_encrypt_multi_bit_pbs_decrypt_custom_mod<
     Scalar: UnsignedTorus + Sync + Send + CastFrom<usize> + CastInto<usize>,
 >(
-    params: &MultiBitParams<Scalar>,
+    params: &MultiBitTestParams<Scalar>,
 ) {
     assert!(Scalar::BITS <= 64);
 
@@ -189,31 +176,3 @@ fn lwe_encrypt_multi_bit_pbs_decrypt_custom_mod<
 }
 
 create_gpu_multi_bit_parametrized_test!(lwe_encrypt_multi_bit_pbs_decrypt_custom_mod);
-
-// DISCLAIMER: these toy example parameters are not guaranteed to be secure or yield
-// correct computations
-const TEST_PARAMS_MULTI_BIT_2_2_2: MultiBitParams<u64> = MultiBitParams {
-    input_lwe_dimension: LweDimension(818),
-    lwe_modular_std_dev: StandardDev(1.3880686109937e-11),
-    decomp_base_log: DecompositionBaseLog(22),
-    decomp_level_count: DecompositionLevelCount(1),
-    glwe_dimension: GlweDimension(1),
-    polynomial_size: PolynomialSize(2048),
-    glwe_modular_std_dev: StandardDev(1.1919984450689246e-23),
-    message_modulus_log: CiphertextModulusLog(4),
-    ciphertext_modulus: CiphertextModulus::new_native(),
-    grouping_factor: LweBskGroupingFactor(2),
-};
-
-const TEST_PARAMS_MULTI_BIT_2_2_3: MultiBitParams<u64> = MultiBitParams {
-    input_lwe_dimension: LweDimension(888),
-    lwe_modular_std_dev: StandardDev(0.0000006125031601933181),
-    decomp_base_log: DecompositionBaseLog(21),
-    decomp_level_count: DecompositionLevelCount(1),
-    glwe_dimension: GlweDimension(1),
-    polynomial_size: PolynomialSize(2048),
-    glwe_modular_std_dev: StandardDev(0.0000000000000003152931493498455),
-    message_modulus_log: CiphertextModulusLog(4),
-    ciphertext_modulus: CiphertextModulus::new_native(),
-    grouping_factor: LweBskGroupingFactor(3),
-};
diff --git a/tfhe/src/core_crypto/gpu/algorithms/test/lwe_programmable_bootstrapping.rs b/tfhe/src/core_crypto/gpu/algorithms/test/lwe_programmable_bootstrapping.rs
@@ -172,23 +172,3 @@ fn lwe_encrypt_pbs_decrypt<
 }
 
 create_gpu_parametrized_test!(lwe_encrypt_pbs_decrypt);
-
-// DISCLAIMER: all parameters here are not guaranteed to be secure or yield correct computations
-pub const TEST_PARAMS_4_BITS_NATIVE_U64: ClassicTestParams<u64> = ClassicTestParams {
-    lwe_dimension: LweDimension(742),
-    glwe_dimension: GlweDimension(1),
-    polynomial_size: PolynomialSize(2048),
-    lwe_modular_std_dev: StandardDev(4.9982771e-11),
-    glwe_modular_std_dev: StandardDev(8.6457178e-32),
-    pbs_base_log: DecompositionBaseLog(23),
-    pbs_level: DecompositionLevelCount(1),
-    ks_level: DecompositionLevelCount(5),
-    ks_base_log: DecompositionBaseLog(3),
-    pfks_level: DecompositionLevelCount(1),
-    pfks_base_log: DecompositionBaseLog(23),
-    pfks_modular_std_dev: StandardDev(0.00000000000000029403601535432533),
-    cbs_level: DecompositionLevelCount(0),
-    cbs_base_log: DecompositionBaseLog(0),
-    message_modulus_log: CiphertextModulusLog(4),
-    ciphertext_modulus: CiphertextModulus::new_native(),
-};
diff --git a/tfhe/src/core_crypto/gpu/algorithms/test/mod.rs b/tfhe/src/core_crypto/gpu/algorithms/test/mod.rs
@@ -40,8 +40,8 @@ macro_rules! create_gpu_multi_bit_parametrized_test{
      ($name:ident)=> {
         create_gpu_multi_bit_parametrized_test!($name
         {
-            TEST_PARAMS_MULTI_BIT_2_2_2,
-            TEST_PARAMS_MULTI_BIT_2_2_3
+            MULTI_BIT_2_2_2_PARAMS,
+            MULTI_BIT_2_2_3_PARAMS
         });
     };
 }