Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update data for the 0.9 breaking change #26

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

IceTDrinker
Copy link
Member

No description provided.

@IceTDrinker IceTDrinker force-pushed the am/chore/make-ks-level-order-consistent branch 7 times, most recently from 2ae907e to eea15a2 Compare October 17, 2024 16:21
@IceTDrinker IceTDrinker force-pushed the am/chore/make-ks-level-order-consistent branch from eea15a2 to 25a7f8c Compare October 18, 2024 14:22
@nsarlin-zama
Copy link
Collaborator

There are some fixes to do in the README, in "usage" v0.1 should be changed to v0.3 (I forgot to do it for 0.2) and in "Adding a new tfhe-rs release", data_0.6.rs changed to data_0.8.rs

@IceTDrinker
Copy link
Member Author

thanks will check those

Copy link
Collaborator

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall !

Since the the HlCiphertextList test is not used anymore (it was the homogeneous lists of pre < 0.7). We could rename the HlHeterogeneousCiphertextListTest to HlCiphertextList since there is no more ambiguity. This would require to update the test on the corresponding PR.

src/generate.rs Show resolved Hide resolved
@IceTDrinker IceTDrinker force-pushed the am/chore/make-ks-level-order-consistent branch from 25a7f8c to 75746b9 Compare October 18, 2024 16:24
@IceTDrinker IceTDrinker force-pushed the am/chore/make-ks-level-order-consistent branch from 75746b9 to 180f26a Compare October 18, 2024 16:58
Copy link
Collaborator

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@zama-bot
Copy link

PR merged because the corresponding PR in main repo was merged: zama-ai/tfhe-rs#1690

@zama-bot zama-bot merged commit be7757a into main Oct 22, 2024
1 check passed
@zama-bot zama-bot deleted the am/chore/make-ks-level-order-consistent branch October 22, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants