Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: progagate tfhe events do database #302

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat: progagate tfhe events do database #302

merged 1 commit into from
Feb 18, 2025

Conversation

rudy-6-4
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 10, 2025
@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch 3 times, most recently from 543fe48 to 3f26fe2 Compare February 11, 2025 13:48
@rudy-6-4 rudy-6-4 changed the base branch from main to rudy/chore/alter_computations_drop_output_type February 11, 2025 13:55
@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch from 3f26fe2 to f9c461a Compare February 11, 2025 16:27
@rudy-6-4 rudy-6-4 marked this pull request as ready for review February 13, 2025 13:00
@rudy-6-4
Copy link
Contributor Author

mmm tests and new tests should be played by the CI ?

@0xawaz
Copy link
Collaborator

0xawaz commented Feb 13, 2025

mmm tests and new tests should be played by the CI ?

it's because we only run test for PRs that are into main

0xawaz
0xawaz approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@0xawaz 0xawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rudy-6-4 rudy-6-4 force-pushed the rudy/chore/alter_computations_drop_output_type branch 2 times, most recently from 7d101c5 to 00e0e15 Compare February 13, 2025 14:49
Base automatically changed from rudy/chore/alter_computations_drop_output_type to main February 13, 2025 15:05
@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch 3 times, most recently from a30217a to 3e8ab51 Compare February 14, 2025 13:19
@rudy-6-4
Copy link
Contributor Author

rudy-6-4 commented Feb 14, 2025 •
edited
Loading

Note: tracing/log and persitence of catchup block number will be done in a next PR.

@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch from 3e8ab51 to 61891d7 Compare February 14, 2025 13:25
@rudy-6-4 rudy-6-4 requested a review from dartdart26 February 14, 2025 13:26
@rudy-6-4
Copy link
Contributor Author

https://github.com/zama-ai/planning-blockchain/issues/427

@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch 4 times, most recently from d5af92d to 64b06bc Compare February 14, 2025 15:36
dartdart26
dartdart26 reviewed Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Mostly minor comments re dependencies.

fhevm-engine/coprocessor/Cargo.toml
@@ -56,6 +56,7 @@ nightly-avx512 = ["tfhe/nightly-avx512"]

[dev-dependencies]
testcontainers = "0.21"
fhevm-listener = { path = "../fhevm-listener" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it wouldn't be better if we put whatever dependency there is between coprocessor and fhevm-listener in fhevm-engine-common? That way, we don't have direct dependencies between components. Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is only for an integration tests in coprocessor.
So the test could be moved somewhere else.
The part is the one doing the database write. Could have end-up in coprocessor as well but it would imply the listener depending on coprocessor and having conversion from events in coprocessor.

fhevm-engine/fhevm-listener/src/bin/main.rs Show resolved Hide resolved
fhevm-engine/fhevm-listener/src/bin/main.rs Show resolved Hide resolved
fhevm-engine/fhevm-listener/src/database/tfhe_event_propagate.rs Outdated Show resolved Hide resolved
fhevm-engine/fhevm-listener/src/database/tfhe_event_propagate.rs Outdated Show resolved Hide resolved
fhevm-engine/fhevm-listener/src/database/tfhe_event_propagate.rs Show resolved Hide resolved
fhevm-engine/listener/Cargo.toml Outdated Show resolved Hide resolved
fhevm-engine/listener/Cargo.toml Outdated Show resolved Hide resolved
@rudy-6-4 rudy-6-4 mentioned this pull request Feb 17, 2025
Open
@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch 2 times, most recently from c555f12 to fc1f446 Compare February 17, 2025 16:19
@rudy-6-4 rudy-6-4 force-pushed the rudy/feat/event-tfhe-operation-to-db branch 2 times, most recently from 297cd62 to 9978e3c Compare February 18, 2025 13:19
@rudy-6-4 rudy-6-4 merged commit 43d7518 into main Feb 18, 2025
11 checks passed
@rudy-6-4 rudy-6-4 deleted the rudy/feat/event-tfhe-operation-to-db branch February 18, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartdart26 dartdart26 dartdart26 left review comments

@0xawaz 0xawaz 0xawaz approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudy-6-4 @0xawaz @dartdart26