-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix security vulns #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (you could use shellcheck when adding shell to check for issues, here some double quotes are asked but seems gtg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've scanned the fhevm-backend
repo and it has 22 vulns reported by Trivy.
- 15 vulns in the code base (rust, golang, etc.)
- 7 misconfig all Dockerfiles
- 3 misconfigs are about non-root user -> I added it to Trivy Ignore File till 2025-03-01 where they should be fixed.
- 4 misconfig are about HEALTHCHECK -> I added it to Trivy Ignore File.
I've scanned the zama-ai/fhevm-db-migration:latest
docker image and Trivy found over 3000 vulns. Like fhevm-backend
repo I created its corresponding trivyignorefile.img.fhevm-db-migration.yaml and added all vulns IDs with LOW score, and other misconfis; now Trivy detected 2839 vulns.
You can update both trivy ignore files:
My recommendation is reduce as low as possible the vulns found in docker image because it has too much.
The good new is that many of them come from linux packages installed in the docker base image. If you replace that, then you will get less vulns.
@chilcano I upgraded rust from |
@aquint-zama shellcheck issues are fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good.
No description provided.