-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #105] Task:make postgres operator installation optional #150
[Fixes #105] Task:make postgres operator installation optional #150
Conversation
…5_Task_postgres-operator_installation_optional
…5_Task_postgres-operator_installation_optional
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9671131 | Triggered | Generic Database Assignment | 1a6c222 | minikube-values-external-db.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Quite a breaking change but you documented it clearly. I would have avoid to bring not related stuff in the PR (like renaming unrelated fields or removing postgres operatore UI) but looking good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment.
Looking good to me
Description
CHANGED VALUES.YAML. This may not be compatible with previous versions.
This issue target the situation that you already have a postgres-operator running in your cluster and want to use it without using the external database configuration in geonode-k8s.
So from now on user can choose what kind of postgres type the gonna use by setting the
postgres.type
variable ether tooperator
orexternal
. If your're using the operator you can further decide to install the postgres-operator into your cluster by setting thepostgres-operator.enabled = True
, if not geonode-k8s expects a postgres operator to be available inside your cluster.When setting
postgres.type
toexternal
you need to set your database passwords inside the values.yaml like describe in docs/external_database or provide an self spinned secret set defined in:postgres.external.secret.existingSecretName
.Type of Change
Please select the relevant option:
Related Issue
If there is an existing issue related to this pull request, please reference it here.
closes #105
Checklist
Please ensure that your pull request meets the following requirements:
Additional Notes
Any additional information or context regarding the pull request can be provided here.
Thank you for creating this pull request