Replace System Rules with System Lambda

[stefanbirkner]

System Lambda is more specific. It only wraps the part of the code that
reads the environment variables. In addition System Lambda is
independent from the test framework and no obstacle for moving to
another test framework (e.g. JUnit Lambda).

[codecov-io]

Codecov Report

Merging #223 (4748282) into master (09a70eb) will decrease coverage by 3.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
- Coverage     75.61%   72.55%   -3.07%     
+ Complexity      259      245      -14     
============================================
  Files            48       48              
  Lines           849      849              
  Branches         40       40              
============================================
- Hits            642      616      -26     
- Misses          183      209      +26     
  Partials         24       24              

Impacted Files	Coverage Δ	Complexity Δ
...c/main/java/org/zalando/stups/tokens/mcb/Open.java	0.00% <0.00%> (-68.00%)	0.00% <0.00%> (-7.00%)
...main/java/org/zalando/stups/tokens/mcb/Closed.java	76.92% <0.00%> (-15.39%)	5.00% <0.00%> (-1.00%)
...n/java/org/zalando/stups/tokens/mcb/MCBConfig.java	80.00% <0.00%> (-13.34%)	2.00% <0.00%> (-4.00%)
...rc/main/java/org/zalando/stups/tokens/mcb/MCB.java	75.00% <0.00%> (-8.34%)	4.00% <0.00%> (-1.00%)
...org/zalando/stups/tokens/AccessTokenRefresher.java	83.58% <0.00%> (-2.99%)	17.00% <0.00%> (-1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a70eb...8cf523e. Read the comment docs.

[vadeg]

Thank you @stefanbirkner !

[vadeg]

👍

[vadeg]

👍

[vadeg]

Requires #241 to be merged first, because Coveralls uses a token, but GH doesn't share tokens with builds running from forks.

[vadeg]

👍

[tkrop]

👍

[tkrop]

But is there something missing to make the test effective?

[tkrop]

I have to correct my before statement. Looking into https://app.codecov.io/gh/zalando/tokens/compare/223/changes shows, that there should by no coverage difference.

[codecov-commenter]

Codecov Report

Merging #223 (4253a32) into master (4f468af) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #223   +/-   ##
=========================================
  Coverage     75.61%   75.61%           
  Complexity      259      259           
=========================================
  Files            48       48           
  Lines           849      849           
  Branches         40       40           
=========================================
  Hits            642      642           
  Misses          183      183           
  Partials         24       24           

Flag	Coverage Δ
unittests	75.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f468af...4253a32. Read the comment docs.