-
Notifications
You must be signed in to change notification settings - Fork 66
Add note about async initialisation of tokens in K8S #203
base: master
Are you sure you want to change the base?
Add note about async initialisation of tokens in K8S #203
Conversation
With thanks to Alexey Ermakov. Full details will be provided in the PR description because I'm not sure Markdown works in the commit description.
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
============================================
+ Coverage 72.55% 72.79% +0.23%
Complexity 245 245
============================================
Files 48 48
Lines 849 849
Branches 40 40
============================================
+ Hits 616 618 +2
+ Misses 209 207 -2
Partials 24 24
Continue to review full report at Codecov.
|
Not sure how adding a little to the README could increase code coverage, but I'm not gonna argue 😆 |
👍 |
1 similar comment
👍 |
@szuecs can you merge this, or is it no longer needed? |
👍 |
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
============================================
+ Coverage 72.55% 72.79% +0.23%
Complexity 245 245
============================================
Files 48 48
Lines 849 849
Branches 40 40
============================================
+ Hits 616 618 +2
+ Misses 209 207 -2
Partials 24 24
Continue to review full report at Codecov.
|
👍 |
@vadeg should be able to merge |
When used in Kubernetes, I observed a persistent failure with an error message like this:
This has the look of a race condition about it. After I raised the issue on an internal Zalando chat channel, Alexey Ermakov provided a helpful explanation:
The PR adds an example to the README with a single line of code shared by Alexey which forces the filesystem refresher to initialise and validate the tokens immediately on startup, which avoids this issue.