filters/auth: implement opt-out support for jwtMetrics #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
szuecs
reviewed
Apr 19, 2024
Extend configuration of `jwtMetrics` (#3020) to support opt-out - disable metrics collection when any of the configured route annotations (#3022) is present. This can be used to collect data about missing/invalid JWT tokens per hostname in multitenant ingress setup. Add `jwtMetrics` filter to all routes using `-default-filters-append` flag and allow users to annotate routes that do not require JWT token. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
filters/auth/jwtMetrics-opt-out
branch
from
8976d88
to
03e1ce3
Compare
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 22, 2024
[Changes](zalando/skipper@v0.21.54...v0.21.62) * zalando/skipper#3025 * zalando/skipper#3031 * zalando/skipper#3033 * zalando/skipper#3032 * zalando/skipper#3030 * zalando/skipper#3027 * zalando/skipper#3028 * zalando/skipper#3023 * zalando/skipper#3020 * zalando/skipper#3022 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend configuration of
jwtMetrics(#3020) to support opt-out - disable metrics collection when any of the configured route annotations (#3022) is present.This can be used to collect data about missing/invalid JWT tokens per hostname in multitenant ingress setup.
Add
jwtMetricsfilter to all routes using-default-filters-appendflag and allow users to annotate routes that do not require JWT token.