proxy: fix proxy panic caused by broken backend #2984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
proxy/fix-go53808
branch
from
96f4184 to
aaffc22
Compare
| @@ -192,9 +192,9 @@ func (c *context) shunted() bool { | |||
| return c.servedWithResponse | |||
| } | |||
|
|
|||
| func (c *context) setResponse(r *http.Response, preserveOriginal bool) { | |||
There was a problem hiding this comment.
Decided to cleanup this although its unrelated
Comment on lines
-1543
to
-1550
| defer func() { | ||
| if ctx.response != nil && ctx.response.Body != nil { | ||
| err := ctx.response.Body.Close() | ||
| if err != nil { | ||
| ctx.Logger().Errorf("error during closing the response body: %v", err) | ||
| } | ||
| } | ||
| }() |
There was a problem hiding this comment.
Decided not to pile-up defers but to use straightforward cleanup sequence after streaming the response.
Would like to refactor other defers as well separately.
| // based on the augmented incoming request | ||
| func (p *Proxy) mapRequest(ctx *context, requestContext stdlibcontext.Context) (*http.Request, routing.Metrics, error) { |
There was a problem hiding this comment.
Maybe rename to createOutgoingRequest?
AlexanderYastrebov
force-pushed
the
proxy/fix-go53808
branch
2 times, most recently
from
65b2792 to
13dac9e
Compare
Broken backend that closes connection before sending response body may trigger proxy panic if client sends `Expect: 100-continue` header, see golang/go#53808 Signed-off-by: Alexander Yastrebov <[email protected]>
Close outgoing request body to fix proxy panic. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
proxy/fix-go53808
branch
from
13dac9e to
e22888a
Compare
|
The plan is to fix the stdlib, see golang/go#66594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken backend that closes connection before sending response body may trigger proxy panic if client sends
Expect: 100-continueheader, see golang/go#53808Close outgoing request body to fix proxy panic.