config: expose FlagSet #2959
Merged
config: expose FlagSet #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Meyer <[email protected]>
wndhydrnt
force-pushed
the
expose-config-flagset
branch
from
b1d638f to
05ec684
Compare
szuecs
reviewed
Feb 27, 2024
Signed-off-by: Markus Meyer <[email protected]>
wndhydrnt
force-pushed
the
expose-config-flagset
branch
from
2bfbcb4 to
4f4ae0c
Compare
|
👍 |
|
Tests need also a change to set or use the member as far as I see go actions output |
Signed-off-by: Markus Meyer <[email protected]>
wndhydrnt
commented
Mar 1, 2024
| @@ -336,8 +336,8 @@ func Test_NewConfigWithArgs(t *testing.T) { | |||
| } | |||
|
|
|||
| if !tt.wantErr { | |||
| if cmp.Equal(cfg, tt.want, cmp.AllowUnexported(listFlag{}, pluginFlag{}, defaultFiltersFlags{}, mapFlags{}), cmpopts.IgnoreUnexported(Config{})) == false { | |||
| t.Errorf("config.NewConfig() got vs. want:\n%v", cmp.Diff(cfg, tt.want, cmp.AllowUnexported(listFlag{}, pluginFlag{}, defaultFiltersFlags{}, mapFlags{}), cmpopts.IgnoreUnexported(Config{}))) | |||
| if cmp.Equal(cfg, tt.want, cmp.AllowUnexported(listFlag{}, pluginFlag{}, defaultFiltersFlags{}, mapFlags{}), cmpopts.IgnoreUnexported(Config{}), cmpopts.IgnoreFields(Config{}, "Flags")) == false { | |||
There was a problem hiding this comment.
@szuecs The failing test has been addressed. Before this PR, the value of Config.flags was not considered for comparison during these tests because of cmpopts.IgnoreUnexported(Config{}). Added cmpopts.IgnoreFields(Config{}, "Flags") to re-create the behavior of ignoring the field.
|
👍 |
|
Thank you! |
|
👍 |
|
Thanks for the reviews and the merge! |
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using skipper as a library. Configuration for custom code, like filters, gets passed in via command-line flags.
This worked well until #2248 got merged, which switched to a
flag.FlagSetto manage configuration. Now, starting Skipper and passing in custom flags fails with the errorflag provided but not defined.This change adds a method that makes the
FlagSetaccessible from outside. It allows users to add custom flags to the `FlagSet.