feature: choose benchmark binary to test local modifications #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandor Szücs <[email protected]>
|
👍 |
| exit 0 | ||
| fi | ||
|
|
||
| source $GOPATH/src/github.com/zalando/skipper/skptesting/benchmark.inc |
There was a problem hiding this comment.
Is this moved due to missing log()?
The downside is that benchmark.inc now installs skipper even if someone just ran it with -help
There was a problem hiding this comment.
Maybe just change it to echo ""benchmark-proxy.sh [duration] ..." >&2. I think it may also print to stdout since its not an error but help message
There was a problem hiding this comment.
yes it is required to use log()
There was a problem hiding this comment.
I guess it does not hurt to install a current local skipper
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: choose benchmark binary to test local modifications