Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fadeIn CI tests #2853

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Improve fadeIn CI tests #2853

merged 1 commit into from
Jan 15, 2024

Conversation

RomanZavodskikh
Copy link
Member

  • added tests for powerOfNRandomChoices monotony
  • added tests for case when all endpoints are new
  • added tests (obviously failing at the moment) for powerOfNRandomChoices to check new and old enpoints receive correct amount of requests

Improve fadeIn CI tests
cf1745f 
+ added tests for powerOfNRandomChoices monotony
+ added tests for case when all endpoints are new
+ added tests (obviously failing at the moment) for powerOfNRandomChoices
to check new and old enpoints receive correct amount of requests

Signed-off-by: Roman Zavodskikh <[email protected]>
@RomanZavodskikh RomanZavodskikh added the minor no risk changes, for example new filters label Jan 12, 2024
@szuecs
Copy link
Member

szuecs commented Jan 12, 2024

👍

@AlexanderYastrebov
Copy link
Member

added tests (obviously failing at the moment) for powerOfNRandomChoices

I am confused, the build is green

@RomanZavodskikh
Copy link
Member Author

I am confused, the build is green

That's because I commented failing test not to fail the whole build because of fadeIn not added to powerOfNRandom choices (and never had been).
The test for three other algorithms (random, round-robin, consistent-hash) are green, so there were no need to comment them.

When I will fix this problem, I will uncomment the test for powerOfNRandomChoices.

@RomanZavodskikh
Copy link
Member Author

👍

@RomanZavodskikh
Copy link
Member Author

RomanZavodskikh commented Jan 15, 2024 •
edited
Loading

Merging this PR because:

  • I have enough approvals
  • It does not affect production code
  • It does not seem too complex (it doesn't seem complex at all)
  • Mixed with the next PR, it may become too complex, so I better separate them

Still feel free to leave your comments here if any, I will fix them in the next PR.

@RomanZavodskikh RomanZavodskikh merged commit e8c099f into master Jan 15, 2024
14 checks passed
@RomanZavodskikh RomanZavodskikh deleted the testPowerOfNRandomChoices branch January 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor no risk changes, for example new filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanZavodskikh @szuecs @AlexanderYastrebov