eskip: add comment test cases for ParsePredicates #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls also add |
AlexanderYastrebov
force-pushed
the
eskip/invalid-does-not-fail
branch
from
1e4a96b
to
51e73f2
Compare
eskip/eskip_test.go
Outdated
| @@ -386,16 +386,22 @@ func TestPredicateParsing(t *testing.T) { | |||
| }, { | |||
| title: "star notation", | |||
| input: `*`, | |||
| }, { | |||
| title: "invalid fuzz 1", | |||
| input: `///`, | |||
There was a problem hiding this comment.
Well, // is an eskip comment
eskip/eskip_test.go
Outdated
| }, { | ||
| title: "invalid fuzz 2", | ||
| input: "\x2f\x2f\x00\x00\x00\xe6\xfe\x00\x00\x2f\x00\x00\x00\x00\x00\x00\x00\xe6\xfe\x00\x00\x2f\x00\x00\x00\x00", | ||
| fail: true, |
There was a problem hiding this comment.
\x2f\x2f... == //... - a comment
AlexanderYastrebov
force-pushed
the
eskip/invalid-does-not-fail
branch
from
51e73f2
to
fe1ead1
Compare
Add test cases from #2755 discovered by fuzzing. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
eskip/invalid-does-not-fail
branch
from
fe1ead1
to
3382963
Compare
AlexanderYastrebov
changed the title
|
👍 |
1 similar comment
|
👍 |
|
We should also fix |
AlexanderYastrebov
added a commit
that referenced
this pull request
Jan 15, 2024
Followup on #2849 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jan 15, 2024
Followup on #2849 Signed-off-by: Alexander Yastrebov <[email protected]>
|
I have added comments to the fuzzer dictionary to guide the fuzzer to use it more |
AlexanderYastrebov
added a commit
that referenced
this pull request
Jan 17, 2024
Followup on #2849 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases from #2755 discovered by fuzzing.