Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclients/kubernetes: enable network backend address validation #2825

Conversation

MustafaSaber
Copy link
Member

Revert "dataclients/kubernetes: disable network backend address validation (#2780)"

This reverts commit 4502bb6.

@MustafaSaber MustafaSaber added the major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs label Jan 4, 2024
@MustafaSaber MustafaSaber self-assigned this Jan 4, 2024
…ation (#2780)"

This reverts commit 4502bb6.

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@MustafaSaber MustafaSaber force-pushed the dataclients/kubernetes/definitions-enable-network-backend-address-validation branch from b1cd76c to fb0e20a Compare January 4, 2024 16:30
@RomanZavodskikh
Copy link
Member

👍

@MustafaSaber
Copy link
Member Author

We need to update our data first before merging this one

@MustafaSaber
Copy link
Member Author

Report was updated and we have no production clusters that will be affected, we can move forward now

@MustafaSaber
Copy link
Member Author

👍

@MustafaSaber MustafaSaber merged commit 80234b7 into master Jan 19, 2024
14 checks passed
@MustafaSaber MustafaSaber deleted the dataclients/kubernetes/definitions-enable-network-backend-address-validation branch January 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants