routesrv: accept gzip encoding #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please create the PR on top of cw2023freeze |
AlexanderYastrebov
force-pushed
the
routesrv/accept-gzip-encoding
branch
from
1cb2383
to
a4f8037
Compare
AlexanderYastrebov
force-pushed
the
routesrv/accept-gzip-encoding
branch
from
a4f8037
to
ff88c27
Compare
AlexanderYastrebov
force-pushed
the
routesrv/accept-gzip-encoding
branch
from
ff88c27
to
63be56d
Compare
| w.Header().Set(routing.RoutesCountName, strconv.Itoa(count)) | ||
|
|
||
| if strings.Contains(r.Header.Get("Accept-Encoding"), "gzip") && len(zdata) > 0 { | ||
| w.Header().Set("Etag", `"`+hash+`+gzip"`) |
There was a problem hiding this comment.
yeah, I thought about it but it scatches me to use printf to add quotes
There was a problem hiding this comment.
w.Header().Set("Etag", `"`+hash+`"`)
w.Header().Set("Etag", `"`+hash+`+gzip"`)
// vs
w.Header().Set("Etag", fmt.Sprintf(`"%s"`, hash))
w.Header().Set("Etag", fmt.Sprintf(`"%s+gzip"`, hash))There was a problem hiding this comment.
I don't know if %q makes it better
fmt.Sprintf("%q", hash)
fmt.Sprintf("%q", hash+"+gzip")
There was a problem hiding this comment.
maybe: fmt.Sprintf("%qgzip", hash)
There was a problem hiding this comment.
ah no this does not work https://go.dev/play/p/xy_341u63TE.
I think @AlexanderYastrebov already tried the best one, in case he wants to have a string like:
"...gzip" and not "..."gzip
Support gzip encoding to reduce response size. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
routesrv/accept-gzip-encoding
branch
from
63be56d
to
7c387d1
Compare
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Nov 27, 2023
Support gzip encoding to reduce response size. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Nov 27, 2023
Support gzip encoding to reduce response size. Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support gzip encoding to reduce response size.