Added support of fadeIn in powerOfNRandomChoices #2702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make lifo, lifoGroup and fifo filters backed error aware and remove cleanup from the proxy. Follow up on #1054, #1086 and #2239 Updates #1238 Signed-off-by: Alexander Yastrebov <[email protected]>
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <[email protected]>
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <[email protected]>
* Don't allow more than one filter/predicate per yaml/json item Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
force-pushed
the
fadeInPowerOfRandomChoices
branch
from
631d6b2
to
415b905
Compare
AlexanderYastrebov
force-pushed
the
cw2023freeze
branch
from
803d0c9
to
ede5467
Compare
|
The problem this PR is aiming to solve is solved automatically with #2634. This PR decouples fade-in logic from loadbalancer, which increases readability and debugability a lot. The fix of fade-in for powerOfNRandomChoices is nice side-effect of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://opensource.zalando.com/skipper/reference/filters/#fadein
fix: #2701