fix flaky test #2513
Merged
fix flaky test #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundTrip and transport to do the request Signed-off-by: Sandor Szücs <[email protected]>
|
Works on my machine :) ]% go test ./filters/tee -run TestTeeEndToEndBody2TeeRoutesAndClosing -count 100 |
|
#2443 fixes the other flaky test (admission control test) |
|
👍 |
Comment on lines
+259
to
+261
| rt := net.NewTransport(net.Options{}) | ||
| defer rt.Close() | ||
| rsp, err := rt.RoundTrip(req) |
There was a problem hiding this comment.
You should use proxy.Client() which is https://pkg.go.dev/net/http/httptest#Server.Client
There was a problem hiding this comment.
I think I misunderstood the problem this is fixing.
http client can sometimes create more than one request
Maybe its worth expanding when this can happen and how it is related to the flaky test this fixes.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2435 stdlib http client can sometimes create more than one request, so use RoundTrip and transport instead