Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook: validate skipper annotations in ingress #2493

Merged
merged 11 commits into from
Aug 10, 2023
Merged

webhook: validate skipper annotations in ingress #2493

merged 11 commits into from
Aug 10, 2023

Commits on Aug 9, 2023

  1. Reorder file 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    af6e698 View commit details
    Browse the repository at this point in the history

  2. Introduce skipper ingress annotations validation 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    937a6b1 View commit details
    Browse the repository at this point in the history

  3. Wrap errors to indicate which annotation failed 

    address comments

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bcd6d65 View commit details
    Browse the repository at this point in the history

  4. Add double quotes 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a19b6ce View commit details
    Browse the repository at this point in the history

  5. Use pointer receivers and remove default variable for ingress not nee… 

    …ded for backward comptiability

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    93dc1e2 View commit details
    Browse the repository at this point in the history

  6. Remove redundant comment 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    852dec1 View commit details
    Browse the repository at this point in the history

  7. Use pointer receiver 

    Add validatior to admitter

Export skipper ingress annotations

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a65c5ab View commit details
    Browse the repository at this point in the history

  8. Get rid of shunt for clearer test 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    316ee86 View commit details
    Browse the repository at this point in the history

  9. Rename annotations varaibles 

    Clean admitter functions

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    1db61f5 View commit details
    Browse the repository at this point in the history

  10. Update version 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    94551bb View commit details
    Browse the repository at this point in the history

  11. Revert "Update version" 

    This reverts commit 0cd73f2.

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    53f054d View commit details
    Browse the repository at this point in the history