skipper: fix shutdown test #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-332
to
-335
| t.Logf("ongoing request passing in before shutdown") | ||
| r, err := waitConnGet(testUrl) | ||
| require.NoError(t, err) | ||
| require.Equal(t, 200, r.StatusCode) |
There was a problem hiding this comment.
Here was the problem: request takes 3s so at this point it is 3.5 seconds after shutdown started. The subsequent request surely fails because server has already finished shutting down, i.e. it was not testing shutdown-in-progress.
Make test request in parallel to ensure another request is refused not only after shutdown started but also while shutdown is still in progress (i.e. while test request is still in progress). Verify shutdown completes after test request is finished. Rename tests to have the same prefix. Updates #988 #1865 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
fix-shutdown-test
branch
from
5499ba7
to
c552645
Compare
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make test request in parallel to ensure another request is refused not only after shutdown started but also while shutdown is still in progress (i.e. while test request is still in progress).
Verify shutdown completes after test request is finished.
Rename tests to have the same prefix.
Updates #988 #1865