filters/auth: allow insecure grant flow #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
In theory, Eve stealing the data in the HTTP connection between Alice (client) and Bob (server) could steal ztoken of Alice and authenticate herself as Alice, couldn't she? |
|
That is correct. The feature is meant for local testing. |
|
Related #1775 |
|
Build failed with looks related to testcontainers/testcontainers-go#1359 |
Add a flag to allow insecure grant flow: * issue token cookie without secure attribute * use http schem for callback url Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
filters/grant-insecure
branch
from
d34833b
to
d40e950
Compare
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 1, 2024
Followup on #2203 Followup on #2244 Followup on #2457 Updates #2898 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 5, 2024
Followup on #2203 Followup on #2244 Followup on #2457 Updates #2898 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to allow insecure grant flow: