Skip to content

Commit

Permalink
fix: NewResponseController was added in Go1.20 (#2543)
Browse files Browse the repository at this point in the history
* fix: https://pkg.go.dev/net/http#NewResponseController was added in Go1.20 so we should also tell dependencies that this is a requirement

Signed-off-by: Sandor Szücs <[email protected]>

* fix: github actions should require 1.20 too

Signed-off-by: Sandor Szücs <[email protected]>

---------

Signed-off-by: Sandor Szücs <[email protected]>
  • Loading branch information
szuecs authored Aug 23, 2023
1 parent 7cb9c95 commit e7020fa
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gh-packages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.19'
go-version: '^1.20'

- name: Login to Github Container Registry
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.19'
go-version: '^1.20'
- run: go version
- run: make deps
- run: make check-fmt
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.19'
go-version: '^1.20'
- run: go version
- run: make deps
- run: make check-race
Expand All @@ -34,7 +34,7 @@ jobs:
- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.19'
go-version: '^1.20'
- run: go version
- run: make deps
- run: make check-fmt
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,4 @@ require (
oras.land/oras-go/v2 v2.2.1 // indirect
)

go 1.19
go 1.20

0 comments on commit e7020fa

Please sign in to comment.