Eskip check fails on empty URL on network backend. (#2524)

* Eskip check fails on empty URL on network backend. (#2524)

Signed-off-by: Xavi Ivars <[email protected]>

cmd/eskip/load.go

@@ -84,13 +84,23 @@ func checkRepeatedRouteIds(routes []*eskip.Route) error {
 	ids := map[string]bool{}
 	for _, route := range routes {
 		if ids[route.Id] {
-			return errors.New("Repeating route with id " + route.Id)
+			return fmt.Errorf("repeating route with id %s", route.Id)
 		}
 		ids[route.Id] = true
 	}
 	return nil
 }
 
+func checkEmptyBackends(routes []*eskip.Route) error {
+	for _, route := range routes {
+		if route.BackendType == eskip.NetworkBackend && route.Backend == "" {
+			return fmt.Errorf("route has empty backend: %s", route.Id)
+		}
+	}
+
+	return nil
+}
+
 // load and parse routes, ignore parse errors.
 func loadRoutesUnchecked(in *medium) []*eskip.Route {
 	lr, _ := loadRoutes(in)
@@ -104,6 +114,11 @@ func checkCmd(a cmdArgs) error {
 		return err
 	}
 
+	err = checkEmptyBackends(routes)
+	if err != nil {
+		return err
+	}
+
 	return checkRepeatedRouteIds(routes)
 }
 

cmd/eskip/load_test.go

@@ -142,6 +142,21 @@ func TestCheckRepeatingRouteIds(t *testing.T) {
 	}
 }
 
+func TestCheckEmptyBackend(t *testing.T) {
+	const name = "testFile"
+
+	err := withFile(name, `foo: Method("POST") -> "https://www.example1.org";empty: Method("POST") -> "";`, func(_ *os.File) {
+		err := checkCmd(cmdArgs{in: &medium{typ: file, path: name}})
+		if err == nil || err.Error() != "route has empty backend: empty" {
+			t.Error("Expected an error for empty backend")
+		}
+	})
+
+	if err != nil {
+		t.Error(err)
+	}
+}
+
 func TestCheckEtcdInvalid(t *testing.T) {
 	if testing.Short() {
 		t.Skip()