Skip to content

Commit

Permalink
packaging: remove base image tag (#2546)
Browse files Browse the repository at this point in the history
When hash is specified the tag is ignored, see moby/moby#37866

The tag apparently confused dependabot and prevents it from updating the image:
```
updater | 2023/08/29 00:21:53 INFO <job_714994438> Checking if library/alpine-3 latest needs updating
updater | 2023/08/29 00:21:53 INFO <job_714994438> Latest version is latest
  proxy | 2023/08/29 00:21:53 [018] HEAD https://registry.opensource.zalan.do:443/v2/library/alpine-3/manifests/latest
  proxy | 2023/08/29 00:21:53 [018] 200 https://registry.opensource.zalan.do:443/v2/library/alpine-3/manifests/latest
updater | 2023/08/29 00:21:53 INFO <job_714994438> Pull request already exists for library/alpine-3 with latest version latest
```

Signed-off-by: Alexander Yastrebov <[email protected]>
  • Loading branch information
AlexanderYastrebov authored Aug 29, 2023
1 parent 49fa546 commit a3e6943
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packaging/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG BASE_IMAGE=default
FROM registry.opensource.zalan.do/library/alpine-3:latest@sha256:2213d4d74c39af5313b631cbde2630b4007755b280f0f6b98867f66103b76113 AS default
FROM registry.opensource.zalan.do/library/alpine-3@sha256:2213d4d74c39af5313b631cbde2630b4007755b280f0f6b98867f66103b76113 AS default
FROM ${BASE_IMAGE}
LABEL maintainer="Team Gateway&Proxy @ Zalando SE <[email protected]>"
RUN apk --no-cache add ca-certificates && update-ca-certificates
Expand Down
2 changes: 1 addition & 1 deletion packaging/Dockerfile.arm64
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=linux/arm64 alpine:3@sha256:7144f7bab3d4c2648d7e59409f15ec52a18006a128c733fcff20d3a4a54ba44a
FROM --platform=linux/arm64 alpine@sha256:7144f7bab3d4c2648d7e59409f15ec52a18006a128c733fcff20d3a4a54ba44a
LABEL maintainer="Team Gateway&Proxy @ Zalando SE <[email protected]>"
RUN apk --no-cache add ca-certificates && update-ca-certificates
ADD build/linux/arm64/skipper \
Expand Down
2 changes: 1 addition & 1 deletion packaging/Dockerfile.armv7
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=linux/arm/v7 alpine:3@sha256:7144f7bab3d4c2648d7e59409f15ec52a18006a128c733fcff20d3a4a54ba44a
FROM --platform=linux/arm/v7 alpine@sha256:7144f7bab3d4c2648d7e59409f15ec52a18006a128c733fcff20d3a4a54ba44a
LABEL maintainer="Team Gateway&Proxy @ Zalando SE <[email protected]>"
RUN apk --no-cache add ca-certificates && update-ca-certificates
ADD build/linux/arm/v7/skipper \
Expand Down

0 comments on commit a3e6943

Please sign in to comment.