Address vet issues found in Go 1.22 (#2907)

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
zalando · Feb 7, 2024 · 81aa6a5 · 81aa6a5
1 parent 3082a04
commit 81aa6a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/cmd/webhook/admission/admission.go b/cmd/webhook/admission/admission.go
@@ -120,7 +120,9 @@ func Handler(admitter admitter) http.HandlerFunc {
 		}
 
 		start := time.Now()
-		defer admissionDuration.With(labelValues).Observe(float64(time.Since(start)) / float64(time.Second))
+		defer func() {
+			admissionDuration.With(labelValues).Observe(float64(time.Since(start)) / float64(time.Second))
+		}()
 
 		admResp, err := admitter.admit(request)
 		if err != nil {

diff --git a/proxy/longpoll_test.go b/proxy/longpoll_test.go
@@ -122,6 +122,7 @@ func cancelableRequest(
 	ctx, cancel := stdlibcontext.WithCancel(stdlibcontext.Background())
 	req, err := http.NewRequestWithContext(ctx, method, url, body)
 	if err != nil {
+		cancel()
 		return nil, err
 	}