Address comments

Signed-off-by: Mustafa Abdelrahman <[email protected]>

filters/auth/authclient.go

@@ -94,7 +94,7 @@ func (ac *authClient) getTokenintrospect(token string, ctx filters.FilterContext
 	if rsp.StatusCode != 200 {
 		io.Copy(io.Discard, rsp.Body)
 		if rsp.StatusCode != 403 && rsp.StatusCode != 401 {
-			return nil, fmt.Errorf("token introspection failed with status code: %d", rsp.StatusCode)
+			return nil, fmt.Errorf("failed with status code: %d", rsp.StatusCode)
 		}
 		return nil, errInvalidToken
 	}
@@ -131,7 +131,7 @@ func (ac *authClient) getTokeninfo(token string, ctx filters.FilterContext) (map
 	if rsp.StatusCode != 200 {
 		io.Copy(io.Discard, rsp.Body)
 		if rsp.StatusCode != 403 && rsp.StatusCode != 401 {
-			return nil, fmt.Errorf("token info failed with status code: %d", rsp.StatusCode)
+			return nil, fmt.Errorf("failed with status code: %d", rsp.StatusCode)
 		}
 		return doc, errInvalidToken
 	}

filters/auth/tokeninfo_test.go

@@ -411,28 +411,23 @@ func TestOAuth2Tokeninfo5xx(t *testing.T) {
 		URL:     authServer.URL + testAuthPath,
 		Timeout: testAuthTimeout,
 	}
-	args := []interface{}{testScope}
-
 	t.Logf("ti.options: %#v", opts)
 
 	spec := newOAuthTokeninfoSpec(filters.OAuthTokeninfoAnyScopeName, opts)
 
-	_, err := spec.CreateFilter(args)
-	require.NoError(t, err, "error creating filter")
-
 	fr := make(filters.Registry)
 	fr.Register(spec)
-	r := &eskip.Route{Filters: []*eskip.Filter{{Name: spec.Name(), Args: args}}, Backend: backend.URL}
+	r := eskip.MustParse(fmt.Sprintf(`* -> oauthTokeninfoAnyScope("%s") -> "%s"`, testScope, backend.URL))
 
-	proxy := proxytest.New(fr, r)
+	proxy := proxytest.New(fr, r...)
 	defer proxy.Close()
 
 	req, err := http.NewRequest("GET", proxy.URL, nil)
 	require.NoError(t, err)
 
 	req.Header.Set(authHeaderName, authHeaderPrefix+testToken)
 
-	rsp, err := http.DefaultClient.Do(req)
+	rsp, err := proxy.Client().Do(req)
 	require.NoError(t, err)
 	rsp.Body.Close()